Re: pgsql: Unbreak recovery test on Windows - Mailing list pgsql-committers

From Andrew Dunstan
Subject Re: pgsql: Unbreak recovery test on Windows
Date
Msg-id 65507be5-4e1f-38b5-bfda-3ce8b988dfc5@dunslane.net
Whole thread Raw
In response to Re: pgsql: Unbreak recovery test on Windows  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
On 3/21/21 2:16 PM, Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
>> Ugh.  Is there any reason we need to do those kills before we end the
>> psql processes? If not I'm tempted just to move them - after the psql's
>> are finished it should be safe. At any rate I'll go and test that.
> IIUC, that'd completely destroy the point of the test, which is to make
> sure we clean up when a backend dies unexpectedly.  If we allow the
> psql's to exit then the backend might be able to complete normal cleanup
> before we can SIGKILL it.
>
> Probably the best thing for now is to revert your change and instead
> just skip the whole test script on Windows.
>
>             


OK, will do that.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com




pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: Unbreak recovery test on Windows
Next
From: Andrew Dunstan
Date:
Subject: pgsql: Don't run recover crash_temp_files test in Windows perl