Re: WIP: Covering + unique indexes. - Mailing list pgsql-hackers

From Anastasia Lubennikova
Subject Re: WIP: Covering + unique indexes.
Date
Msg-id 638da278-0bd3-2e10-1a6c-bb2194ffc22e@postgrespro.ru
Whole thread Raw
In response to WIP: Covering + unique indexes.  (Anastasia Lubennikova <a.lubennikova@postgrespro.ru>)
List pgsql-hackers
31.03.2017 20:57, Robert Haas:
> On Fri, Mar 31, 2017 at 1:40 PM, Anastasia Lubennikova
> <a.lubennikova@postgrespro.ru> wrote:
>> First of all, I want to thank you and Robert for reviewing this patch.
>> Your expertise in postgres subsystems is really necessary for features like
>> this.
>> I just wonder, why don't you share your thoughts and doubts till the "last
>> call".
> I haven't done any significant technical work other than review
> patches in 14 months, and in the last several months I've often worked
> 10 and 12 hour days to get more review done.
>
> I think at one level you've got a fair complaint here - it's hard to
> get things committed, and this patch probably didn't get as much
> attention as it deserved.  It's not so easy to know how to fix that.
> I'm pretty sure "tell Andres and Robert to work harder" isn't it.
>

*off-topic*
No complaints from me, I understand how difficult is reviewing and 
highly appreciate your work.
The problem is that not all developers are qualified enough to do a review.
I've tried to make a course about postrges internals. Something like 
"Deep dive into postgres codebase for hackers".
And it turned out to be really helpful for new developers. So, I wonder, 
maybe we could write some tips for new reviewers and testers as well.

-- 
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company




pgsql-hackers by date:

Previous
From: Jesper Pedersen
Date:
Subject: Re: bumping HASH_VERSION to 3
Next
From: David Fetter
Date:
Subject: Re: delta relations in AFTER triggers