Postgres Pro
Downloads
Home   >   mailing lists

Re: tuplesort.c's copytup_index() is dead code - Mailing list pgsql-hackers

From Tom Lane
Subject Re: tuplesort.c's copytup_index() is dead code
Date
Msg-id 6217.1466737147@sss.pgh.pa.us
Whole thread Raw
In response to tuplesort.c's copytup_index() is dead code  (Peter Geoghegan <pg@heroku.com>)
Responses Re: tuplesort.c's copytup_index() is dead code  (Peter Geoghegan <pg@heroku.com>)
Re: tuplesort.c's copytup_index() is dead code  (Peter Geoghegan <pg@heroku.com>)
List pgsql-hackers
Tree view 
Peter Geoghegan <pg@heroku.com> writes:
> Commit 9f03ca915 removed the only COPYTUP() call that could reach
> copytup_index() in practice, making copytup_index() dead code.

> The attached patch removes this dead code,

I think this may be premature in view of bug #14210.  Even if we
don't reinstate use of this function to fix that, I'm not really
convinced we want to get rid of it; it seems likely to me that
we might want it again.
        regards, tom lane

pgsql-hackers by date:

Previous
From: "Tsunakawa, Takayuki"
Date:
Subject: Re: initdb issue on 64-bit Windows - (Was: [pgsql-packagers] PG 9.6beta2 tarballs are ready)
Next
From: Alvaro Herrera
Date:
Subject: Re: Odd behavior with domains