[HACKERS] Update comment in ExecPartitionCheck - Mailing list pgsql-hackers

From Etsuro Fujita
Subject [HACKERS] Update comment in ExecPartitionCheck
Date
Msg-id 61e213a1-6996-4dee-2210-53798df625a3@lab.ntt.co.jp
Whole thread Raw
Responses Re: [HACKERS] Update comment in ExecPartitionCheck
Re: [HACKERS] Update comment in ExecPartitionCheck
List pgsql-hackers
This comment in an error handling in ExecPartitionCheck():

     if (!ExecCheck(resultRelInfo->ri_PartitionCheckExpr, econtext))
     {
         char       *val_desc;
         Relation    orig_rel = rel;

         /* See the comment above. */
         if (resultRelInfo->ri_PartitionRoot)

should be updated because we don't have any comment on that above in the 
code.  Since we have a comment on that in ExecConstraints() defined just 
below that function, I think the comment should be something like this: 
"See the comment in ExecConstraints().".  Attached is a patch for that.

Best regards,
Etsuro Fujita

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Attachment

pgsql-hackers by date:

Previous
From: Etsuro Fujita
Date:
Subject: Re: [HACKERS] UPDATE of partition key
Next
From: Amit Langote
Date:
Subject: Re: [HACKERS] UPDATE of partition key