Conflicting option checking in pg_restore - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Conflicting option checking in pg_restore
Date
Msg-id 616808BD-4B59-4E6C-97A9-7317F62D5570@yesql.se
Whole thread Raw
Responses Re: Conflicting option checking in pg_restore  (Fabien COELHO <coelho@cri.ensmp.fr>)
List pgsql-hackers
Checking for conflicting options in pg_restore was mostly done in main() with
one check deferred until RestoreArchive().  Reading the git history makes it
seem like it simply happened, without the disjoint checking being intentional.
Am I reading it right that we can consolidate all the option checking to
main()?  The attached patch does that, and also rewords the error message to
make it similar to the other option checks.

cheers ./daniel


Attachment

pgsql-hackers by date:

Previous
From: Narayanan V
Date:
Subject: Re: Postgres restore issue
Next
From: Daniel Gustafsson
Date:
Subject: Re: Remove obsolete pg_attrdef.adsrc column