Re: test_fsync label adjustments - Mailing list pgsql-hackers

From Tom Lane
Subject Re: test_fsync label adjustments
Date
Msg-id 6056.1295391969@sss.pgh.pa.us
Whole thread Raw
In response to Re: test_fsync label adjustments  (Bruce Momjian <bruce@momjian.us>)
Responses Re: test_fsync label adjustments  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
Bruce Momjian <bruce@momjian.us> writes:
> Tom Lane wrote:
>> Bruce Momjian <bruce@momjian.us> writes:
>>> I have modified test_fsync to use test labels that match wal_sync_method
>>> values, and and added more tests for open_sync with different sizes. 

>> Given that it was unclear whether the first such test was of any value,
>> why are you slowing down the program by adding more?

> Greg Smith indicated it has value, so I made it more complete.  No?

My recollection of that discussion is a bit different: there wasn't a
clear-cut reason to rip it out.  But the more tests you add to
test_fsync, the less useful it becomes.
        regards, tom lane


pgsql-hackers by date:

Previous
From: "David E. Wheeler"
Date:
Subject: Re: Fixing GIN for empty/null/full-scan cases
Next
From: Tom Lane
Date:
Subject: Re: Fixing GIN for empty/null/full-scan cases