Re: Some belated patch review for "Buffers" explain analyze patch - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Some belated patch review for "Buffers" explain analyze patch
Date
Msg-id 603c8f071002091442v19fb49d9k8f237a4edc627b9c@mail.gmail.com
Whole thread Raw
In response to Re: Some belated patch review for "Buffers" explain analyze patch  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Some belated patch review for "Buffers" explain analyze patch
Re: Some belated patch review for "Buffers" explain analyze patch
List pgsql-hackers
On Tue, Feb 9, 2010 at 5:41 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Robert Haas <robertmhaas@gmail.com> writes:
>> On Tue, Feb 9, 2010 at 5:07 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> Well, if you want to put forward a proposal to get rid of that approach
>>> entirely, go ahead.  But it doesn't seem like a good idea to me for
>>> EXPLAIN to print some numbers according to one viewpoint and some
>>> according to the other.
>
>> Well, if I propose that we just abandon that approach and print only
>> totals for everything, is that DOA?  I think it would be a major
>> improvement, but it will break backward compatibility.
>
> Well, I'm not for changing it, but I might be in the minority.
>
> A more important point is that it would be a nontrivial change, both as
> to code and documentation, and it's too late for such in 9.0.  So what
> we ought to be confining the discussion to right now is what 9.0 should
> print here.

It's exactly as nontrivial as the proposed change in the other direction.

...Robert


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Some belated patch review for "Buffers" explain analyze patch
Next
From: Marko Tiikkaja
Date:
Subject: Re: Writeable CTEs and empty relations