Re: Some belated patch review for "Buffers" explain analyze patch - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Some belated patch review for "Buffers" explain analyze patch
Date
Msg-id 577.1265758402@sss.pgh.pa.us
Whole thread Raw
In response to Re: Some belated patch review for "Buffers" explain analyze patch  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: Some belated patch review for "Buffers" explain analyze patch
List pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> On Tue, Feb 9, 2010 at 5:41 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> A more important point is that it would be a nontrivial change, both as
>> to code and documentation, and it's too late for such in 9.0. �So what
>> we ought to be confining the discussion to right now is what 9.0 should
>> print here.

> It's exactly as nontrivial as the proposed change in the other direction.

Not in the least.  Fixing EXPLAIN to consistently print totals would
involve changes in (at least) the treatment of estimated costs, and very
possibly some changes in the Instrumentation support as well.  I notice
you blithely disregarded the documentation point, too.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: log_error_verbosity placement
Next
From: Greg Stark
Date:
Subject: Re: Some belated patch review for "Buffers" explain analyze patch