Re: need more reviewers for index changes - Mailing list pgsql-rrreviewers

From Robert Haas
Subject Re: need more reviewers for index changes
Date
Msg-id 603c8f070907211008j40bfe769s2ca7f3d025dc935a@mail.gmail.com
Whole thread Raw
In response to Re: need more reviewers for index changes  (Stephen Frost <sfrost@snowman.net>)
Responses Re: need more reviewers for index changes
Re: need more reviewers for index changes
List pgsql-rrreviewers
On Tue, Jul 21, 2009 at 6:40 AM, Stephen Frost<sfrost@snowman.net> wrote:
> Robert,
>
> * Robert Haas (robertmhaas@gmail.com) wrote:
>> It probably makes sense to start with indexam api changes, since the
>> other one depends on that one.
>
> I've looked the patch over, but the problem is that the patch doesn't do
> terribly much by itself, and Tom's already commented on things he
> doesn't like about it.  Alot of the patch here:
> http://archives.postgresql.org/message-id/4A5ADFE6.6060507@enterprisedb.com
> is changing heap_hot_search_buffer to have heapTuple passed in as a
> pointer rather than a local var, which makes for many '.' to '->'
> changes.  The rest is just splitting index_getnext into two pieces.

Ah, yes, I see your point.  So I think this is actually waiting on
author.  We should poke Heikki.

...Robert

pgsql-rrreviewers by date:

Previous
From: Robert Haas
Date:
Subject: Re: CF 2009-07: initial reviewing assignments
Next
From: Jaime Casanova
Date:
Subject: Re: CF 2009-07: initial reviewing assignments