Re: check_recovery_target_lsn() does a PG_CATCH without a throw - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: check_recovery_target_lsn() does a PG_CATCH without a throw
Date
Msg-id 5da47275-9737-77e4-e7ac-26bcd61d1374@2ndquadrant.com
Whole thread Raw
In response to Re: check_recovery_target_lsn() does a PG_CATCH without a throw  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: check_recovery_target_lsn() does a PG_CATCH without a throw
List pgsql-hackers
On 2019-06-12 13:16, Peter Eisentraut wrote:
> I haven't figured out the time zone issue yet, but I guess the solution
> might involve moving some of the code from check_recovery_target_time()
> to assign_recovery_target_time().

I think that won't work either.  What we need to do is postpone the
interpretation of the timestamp string until after all the GUC
processing is done.  So check_recovery_target_time() would just do some
basic parsing checks, but stores the string.  Then when we need the
recovery_target_time_value we do the final parsing.  Then we can be sure
that the time zone is all set.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: old_snapshot_threshold vs indexes
Next
From: Joe Conway
Date:
Subject: Re: [Proposal] Table-level Transparent Data Encryption (TDE) and KeyManagement Service (KMS)