Re: check_recovery_target_lsn() does a PG_CATCH without a throw - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: check_recovery_target_lsn() does a PG_CATCH without a throw
Date
Msg-id 478c8dfc-0c64-c2c3-1e3f-6dd688354e1d@2ndquadrant.com
Whole thread Raw
In response to check_recovery_target_lsn() does a PG_CATCH without a throw  (Andres Freund <andres@anarazel.de>)
Responses Re: check_recovery_target_lsn() does a PG_CATCH without a throw
Re: check_recovery_target_lsn() does a PG_CATCH without a throw
List pgsql-hackers
On 2019-06-11 08:11, Andres Freund wrote:
> While working on fixing [1] I noticed that 2dedf4d9a899 "Integrate
> recovery.conf into postgresql.conf" added two non-rethrowing PG_CATCH
> uses. That's not OK.

Right.  Here is a patch that addresses this by copying the relevant code
from pg_lsn_in() and timestamptz_in() directly into the check hooks.
It's obviously a bit unfortunate not to be able to share that code, but
it's not actually that much.

I haven't figured out the time zone issue yet, but I guess the solution
might involve moving some of the code from check_recovery_target_time()
to assign_recovery_target_time().

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment

pgsql-hackers by date:

Previous
From: Siarhei Siniak
Date:
Subject: Re: GiST limits on contrib/cube with dimension > 100?
Next
From: Konstantin Knizhnik
Date:
Subject: Re: Adaptive query optimization