Re: index_delete_sort: Unnecessary variable "low" is used in heapam.c - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: index_delete_sort: Unnecessary variable "low" is used in heapam.c
Date
Msg-id 5DCA3F10-18DF-4824-8557-7F6C9295810E@yesql.se
Whole thread Raw
List pgsql-hackers
> On 24 Sep 2024, at 10:32, btnakamurakoukil <btnakamurakoukil@oss.nttdata.com> wrote:

> I noticed unnecessary variable "low" in index_delete_sort() (/postgres/src/backend/access/heap/heapam.c), patch
attached.What do you think? 

That variable does indeed seem to not be used, and hasn't been used since it
was committed in d168b666823.  The question is if it's a left-over from
development which can be removed, or if it should be set and we're missing an
optimization.  Having not read the referenced paper I can't tell so adding
Peter Geoghegan who wrote this for clarification.

--
Daniel Gustafsson




pgsql-hackers by date:

Previous
From: Li Japin
Date:
Subject: Re: [PATCH] Support Int64 GUCs
Next
From: Alastair Turner
Date:
Subject: Re: Add llvm version into the version string