Re: Problems with plan estimates in postgres_fdw - Mailing list pgsql-hackers

From Etsuro Fujita
Subject Re: Problems with plan estimates in postgres_fdw
Date
Msg-id 5C518631.5080401@lab.ntt.co.jp
Whole thread Raw
In response to Re: Problems with plan estimates in postgres_fdw  (Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>)
Responses Re: Problems with plan estimates in postgres_fdw  (Antonin Houska <ah@cybertec.at>)
Re: Problems with plan estimates in postgres_fdw  (Jeff Janes <jeff.janes@gmail.com>)
List pgsql-hackers
(2018/12/28 15:50), Etsuro Fujita wrote:
> Attached is a new version of the
> patch.

Here is an updated version of the patch set.  Changes are:

* In the previous version, LIMIT without OFFSET was not performed 
remotely as the costs was calculated the same as the costs of performing 
it locally.  (Actually, such LIMIT was performed remotely in a case in 
the postgres_fdw regression test, but that was due to a bug :(.)  I 
think we should prefer performing such LIMIT remotely as that avoids 
extra row fetches from the remote that performing it locally might 
cause, so I tweaked the costs estimated in estimate_path_cost_size(), to 
ensure that we'll prefer performing such LIMIT remotely.  (I fixed the 
mentioned bug as well.)

* I fixed another bug in adjusting the costs of pre-sorted 
foreign-grouping paths.

* I tweaked comments, and rebased the patch set against the latest HEAD.

Best regards,
Etsuro Fujita

Attachment

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: strange error sequence on parallel btree creation
Next
From: Alvaro Herrera
Date:
Subject: Re: Unused parameters & co in code