Re: Problems with plan estimates in postgres_fdw - Mailing list pgsql-hackers

From Etsuro Fujita
Subject Re: Problems with plan estimates in postgres_fdw
Date
Msg-id 5C25C7B5.2010802@lab.ntt.co.jp
Whole thread Raw
In response to Re: Problems with plan estimates in postgres_fdw  (Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>)
Responses Re: Problems with plan estimates in postgres_fdw  (Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>)
List pgsql-hackers
(2018/12/26 16:35), Etsuro Fujita wrote:
> Attached is an updated version of the patch. Other changes:

While self-reviewing the patch I noticed a thinko in the patch 0001 for 
pushing down the final sort: I estimated the costs for that using 
estimate_path_cost_size that was modified so that it factored the 
limit_tuples limit (if any) into the costs, but I think that was wrong; 
that should not factor that because the remote query corresponding to 
the pushdown step won't have LIMIT.  So I fixed that.  Also, a new data 
structure I added to include/nodes/relation.h (ie, OrderedPathExtraData) 
is no longer needed, so I removed that.  Attached is a new version of 
the patch.

Best regards,
Etsuro Fujita

Attachment

pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: Compiling on Termux
Next
From: Pavel Stehule
Date:
Subject: Re: plpgsql plugin - stmt_beg/end is not called for top level blockof statements