Re: Minor comment update in execPartition.c - Mailing list pgsql-hackers

From Etsuro Fujita
Subject Re: Minor comment update in execPartition.c
Date
Msg-id 5ADFF13F.9070409@lab.ntt.co.jp
Whole thread Raw
In response to Re: Minor comment update in execPartition.c  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
List pgsql-hackers
(2018/04/25 11:05), Alvaro Herrera wrote:
> Amit Langote wrote:
>
>>> I think we should remove the words "if not already done" from that
>>> comment because 1) that function is called if the partition wasn't
>>> already initialized and 2) that function assumes that.  Attached is a
>>> small patch for removing the words.
>>
>> Thanks, sounds fine.  I think those words remain from earlier versions of
>> the patch committed as edd44738bc8 [1], where there used to be a fast-path
>> return if the ResultRelInfo was already non-NULL for the passed in index.
>
> Makes sense -- pushed, thanks both.

Thanks for committing, Alvaro!  Thanks for reviewing, Amit!

Best regards,
Etsuro Fujita


pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: Oddity in tuple routing for foreign partitions
Next
From: Christophe Pettus
Date:
Subject: Re: Built-in connection pooling