Re: Minor comment update in execPartition.c - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Minor comment update in execPartition.c
Date
Msg-id 20180425020509.ypsb2gs3pzaftbgy@alvherre.pgsql
Whole thread Raw
In response to Re: Minor comment update in execPartition.c  (Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>)
Responses Re: Minor comment update in execPartition.c  (Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>)
List pgsql-hackers
Amit Langote wrote:

> > I think we should remove the words "if not already done" from that
> > comment because 1) that function is called if the partition wasn't
> > already initialized and 2) that function assumes that.  Attached is a
> > small patch for removing the words.
> 
> Thanks, sounds fine.  I think those words remain from earlier versions of
> the patch committed as edd44738bc8 [1], where there used to be a fast-path
> return if the ResultRelInfo was already non-NULL for the passed in index.

Makes sense -- pushed, thanks both.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


pgsql-hackers by date:

Previous
From: Kyotaro HORIGUCHI
Date:
Subject: Re: Oddity in tuple routing for foreign partitions
Next
From: Michael Paquier
Date:
Subject: Typo in JIT documentation