Re: [COMMITTERS] pgsql: Add function to import operating systemcollations - Mailing list pgsql-committers

From Peter Eisentraut
Subject Re: [COMMITTERS] pgsql: Add function to import operating systemcollations
Date
Msg-id 57d99bf7-abaa-16bb-7ea8-1ca019c4caf6@2ndquadrant.com
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Add function to import operating system collations  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
On 1/18/17 1:46 PM, Tom Lane wrote:
> I wrote:
>> The previous coding applied a sort so as not to depend on what
>> order "locale -a" had returned things in, and I think we need
>> to retain that.  At the very least, all the normalized names
>> need to be saved up and entered in a second pass.
>
> Actually, it seems like doing precisely that should be enough to fix
> it.  The original names shouldn't have any dups, and if we generate
> dup names by stripping, those will be for different encodings so it's
> OK.  I've pushed a fix based on that.

Yeah, I was just about to write the exact same code.  Looks good, thanks.

--
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [COMMITTERS] pgsql: Add function to import operating system collations
Next
From: Robert Haas
Date:
Subject: [COMMITTERS] pgsql: Factor out logic for computing number of parallel workers.