On Apr 3, 2026 Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> I've updated the patch based on my earlier comments and made some
> cosmetic improvements.
Thanks for comments! I also just made the same changes after your review.
Attaching an updated patch with fixes after your review, some of last
cosmetic changes and two excluded test cases.
There are currently 5 test cases: two for 0ms(empty and full buffers), two
for 10ms (empty and full buffers), and one for the standby case. I think
it is ok to exclude two cases with 0ms to speed up the launch of tests.
> This sentence doesn't seem necessary, as similar GUCs don't mention this
I decided to leave in the documentation a mention of the possibility of
setting a parameter per replication connection. I think some users are not
aware of this possibility and this short sentence might give them the idea.
> It would also be better to move "replication may be incomplete" to
errdetail(),
> and clarify it, for example, "Walsender is terminated before all WAL
data was
> replicated to the receiver".
In some cases, replication may be fully completed even when exiting with
WalSndDoneImmediate, so I edited the message.
Regards,
Andrey Silitskiy
