Re: pgsql: Fix search_path to a safe value during maintenance operations. - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Fix search_path to a safe value during maintenance operations.
Date
Msg-id 573014.1686375211@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Fix search_path to a safe value during maintenance operations.  (Jeff Davis <pgsql@j-davis.com>)
Responses Re: pgsql: Fix search_path to a safe value during maintenance operations.  (Noah Misch <noah@leadboat.com>)
List pgsql-committers
Jeff Davis <pgsql@j-davis.com> writes:
> Attached a patch to mark those functions as PARALLEL UNSAFE, which
> fixes the problem.

> Alternatively, I could just take out that line, as those SQL functions
> are not controlled by the MAINTAIN privilege. But for consistency I
> think it's a good idea to leave it in so that index functions are
> called with the right search path for amcheck.

I concur with the upthread objection that it is way too late in
the release cycle to be introducing a breaking change like this.
I request that you revert it.

            regards, tom lane



pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: pgsql: meson: Add dependencies to perl modules to various script invoca
Next
From: Jeff Davis
Date:
Subject: pgsql: Revert "Fix search_path to a safe value during maintenance opera