Re: Fuzzy substring searching with the pg_trgm extension - Mailing list pgsql-hackers

From Teodor Sigaev
Subject Re: Fuzzy substring searching with the pg_trgm extension
Date
Msg-id 56BC8889.2000005@sigaev.ru
Whole thread Raw
In response to Re: Fuzzy substring searching with the pg_trgm extension  (Artur Zakirov <a.zakirov@postgrespro.ru>)
Responses Re: Fuzzy substring searching with the pg_trgm extension
Re: Fuzzy substring searching with the pg_trgm extension
List pgsql-hackers
> I have attached a new version of the patch. It fixes error of operators <->> and
> %>:
> - operator <->> did not pass the regression test in CentOS 32 bit (gcc 4.4.7
> 20120313).
> - operator %> did not pass the regression test in FreeBSD 32 bit (gcc 4.2.1
> 20070831).
>
> It was because of variable optimization by gcc.

Fixed with volatile modifier, right?

I'm close to push this patches, but I still doubt in names, and I'd like to see 
comment from English speackers:
1 sml_limit GUC variable (options: similarity_limit, sml_threshold)
2 subword_similarity(). Actually, it finds most similar word (not substring!) 
from whole string. word_similarity? word_in_string_similarity?


substring_similarity_pos() could be a separate patch.

-- 
Teodor Sigaev                                   E-mail: teodor@sigaev.ru
  WWW: http://www.sigaev.ru/
 



pgsql-hackers by date:

Previous
From: Rich Jones
Date:
Subject: Request for Code Review: BPGSQL
Next
From: Robert Haas
Date:
Subject: Re: [PATCH] Refactoring of LWLock tranches