On 29/12/2015 00:30, Jeff Janes wrote:
> On Wed, Nov 25, 2015 at 9:29 AM, Jeff Janes <jeff.janes@gmail.com> wrote:
>>
>> I'll prepare a patch for core for the January commitfest, and see if
>> it flies. If not, there is always the extension to fall back to.
>
> Here is an updated patch. I've added type and permission checks,
> docs, and some regression tests.
>
I just reviewed it. Patch applies cleanly, everything works as intended,
including regression tests.
I think the function should be declared as strict.
Also, there are some trailing whitespaces in the documentation diff.
Regards.
> Cheers,
>
> Jeff
>
>
>
>
--
Julien Rouhaud
http://dalibo.com - http://dalibo.org
