Re: oldest/newestCommitTs output by pg_controldata - Mailing list pgsql-hackers

From Joe Conway
Subject Re: oldest/newestCommitTs output by pg_controldata
Date
Msg-id 56817565.80509@joeconway.com
Whole thread Raw
In response to Re: oldest/newestCommitTs output by pg_controldata  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: oldest/newestCommitTs output by pg_controldata
List pgsql-hackers
On 12/28/2015 09:03 AM, Tom Lane wrote:
> Joe Conway <mail@joeconway.com> writes:
>> Ok, but now next question -- should we just change the user visible
>> output to oldestCommitXID/newestCommitXID, or should we change the
>> variable name everywhere it appears in source as well? Looks like each
>> one appears about 25-30 times scattered across 9 or 10 files. Since they
>> are new in 9.5, if we're going to change them, I'd think we ought to do
>> it now or never.
>
> The name is just as misleading at the source-code level, maybe more so
> since they're all just numbers in C.  +1 for changing it everywhere
> before somebody makes a mistake based on the incorrect names.

Ok, I'm on it now

Joe

--
Crunchy Data - http://crunchydata.com
PostgreSQL Support for Secure Enterprises
Consulting, Training, & Open Source Development


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: oldest/newestCommitTs output by pg_controldata
Next
From: Alvaro Herrera
Date:
Subject: Re: oldest/newestCommitTs output by pg_controldata