Re: oldest/newestCommitTs output by pg_controldata - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: oldest/newestCommitTs output by pg_controldata
Date
Msg-id 20151228175320.GK58441@alvherre.pgsql
Whole thread Raw
In response to Re: oldest/newestCommitTs output by pg_controldata  (Joe Conway <mail@joeconway.com>)
Responses Re: oldest/newestCommitTs output by pg_controldata  (Joe Conway <mail@joeconway.com>)
List pgsql-hackers
Joe Conway wrote:
> On 12/28/2015 09:03 AM, Tom Lane wrote:
> > Joe Conway <mail@joeconway.com> writes:
> >> Ok, but now next question -- should we just change the user visible
> >> output to oldestCommitXID/newestCommitXID, or should we change the
> >> variable name everywhere it appears in source as well? Looks like each
> >> one appears about 25-30 times scattered across 9 or 10 files. Since they
> >> are new in 9.5, if we're going to change them, I'd think we ought to do
> >> it now or never.
> > 
> > The name is just as misleading at the source-code level, maybe more so
> > since they're all just numbers in C.  +1 for changing it everywhere
> > before somebody makes a mistake based on the incorrect names.
> 
> Ok, I'm on it now

Great, thanks.



-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Joe Conway
Date:
Subject: Re: oldest/newestCommitTs output by pg_controldata
Next
From: Joe Conway
Date:
Subject: Re: oldest/newestCommitTs output by pg_controldata