Re: [PATCH v1] amcheck: Allow interrupting the child-level rightlink walk - Mailing list pgsql-hackers

On 28/08/2026 07:31, shihao zhong wrote:
> On Sat, Jul 18, 2026 at 3:31 AM 김선동 <mok03127@gmail.com> wrote:
>>> Resending the v2 patch as an attachment so cfbot can pick it up — the earlier copies went inline. No changes to the
patchitself.
 
> 
> Hi Paul,
> 
> Thanks for the patch -- I reviewed it and agree with your justification.
> Every other page-traversal loop in verify_nbtree.c already has a
> CHECK_FOR_INTERRUPTS(), and the rightlink walk in bt_child_highkey_check()
> is the only one that was missing it, so this is a nice consistency fix on
> top of the correctness argument you make in the commit message.
> 
> The placement is also safe, the function and loop doesn't hold a
> buffer content lock
> across iterations.
> 
> LGTM, I think this is good to go.

Committed, thanks.

- Heikki