Re: Better name for PQsslAttributes() - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: Better name for PQsslAttributes()
Date
Msg-id 563D1DE5.8090002@iki.fi
Whole thread Raw
In response to Better name for PQsslAttributes()  (Lars Kanis <lars@greiz-reinsdorf.de>)
Responses Re: Better name for PQsslAttributes()  (Magnus Hagander <magnus@hagander.net>)
Re: Better name for PQsslAttributes()  (Peter Geoghegan <pg@heroku.com>)
Re: Better name for PQsslAttributes()  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 11/06/2015 11:31 PM, Lars Kanis wrote:
> As a co-maintainer of the PostgreSQL adapter for Ruby, I would like to
> bridge the new SSL related functions to Ruby methods. However I wonder
> whether PQsslAttributes() is the best name for the function. Based on
> this name, I would expect to get key+value pairs instead of only the
> keys. IMHO PQsslAttributeNames() would express better, what the function
> does.

Hmm, I think you're right.

The question is, do we want to still change it? It's a new function in 
9.5, and we're just about to enter beta, so I guess we could, although 
there might already be applications out there using it. If we do want to 
rename it, now is the last chance to do it.

Thoughts? I'm leaning towards changing it now.

- Heikki




pgsql-hackers by date:

Previous
From: Lars Kanis
Date:
Subject: Better name for PQsslAttributes()
Next
From: Magnus Hagander
Date:
Subject: Re: Better name for PQsslAttributes()