Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags
Date
Msg-id 5619.1292090426@sss.pgh.pa.us
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags  (Magnus Hagander <magnus@hagander.net>)
Responses Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Magnus Hagander <magnus@hagander.net> writes:
> On Sat, Dec 11, 2010 at 18:46, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I think we can just #define the other cases as zeroes. �I'm not sure why
>> you think that's an issue for open --- the privileges don't exist.

> Hmm. I was/am worried about any case that specifies *just* one of the
> permissions that don't exist. That'll leave it at zero, whereas the
> correct one might be the user-only version of whatever (read/write)
> was given.

If we didn't specify the "user" read or write privilege, we shouldn't
get it.

What are the values of _S_IREAD and _S_IWRITE, anyway?  I'm still
wondering how come the previous coding with hardwired constants
behaved correctly.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags
Next
From: Robert Haas
Date:
Subject: Re: create tablespace fails silently, or succeeds improperly