Re: track_commit_timestamp and COMMIT PREPARED - Mailing list pgsql-hackers

From Petr Jelinek
Subject Re: track_commit_timestamp and COMMIT PREPARED
Date
Msg-id 55EAC861.5000306@2ndquadrant.com
Whole thread Raw
In response to Re: track_commit_timestamp and COMMIT PREPARED  (Fujii Masao <masao.fujii@gmail.com>)
Responses Re: track_commit_timestamp and COMMIT PREPARED  (Fujii Masao <masao.fujii@gmail.com>)
Re: track_commit_timestamp and COMMIT PREPARED  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
On 2015-09-02 16:14, Fujii Masao wrote:
> On Wed, Aug 5, 2015 at 2:16 AM, Robert Haas <robertmhaas@gmail.com> wrote:
>> On Mon, Aug 3, 2015 at 10:31 AM, Fujii Masao <masao.fujii@gmail.com> wrote:
>>> track_commit_timestamp tracks COMMIT PREPARED as expected in standby server,
>>> but not in master server. Is this intentional? It should track COMMIT PREPARED
>>> even in master? Otherwise, we cannot use commit_timestamp feature to check
>>> the replication lag properly while we use 2PC.
>>
>> That sounds like it must be a bug.  I think you should add it to the
>> open items list.
>

Attached fixes this. It includes advancement of replication origin as
well. I didn't feel like doing refactor of commit code this late in 9.5
cycle though, so I went with the code duplication + note in xact.c.

--
  Petr Jelinek                  http://www.2ndQuadrant.com/
  PostgreSQL Development, 24x7 Support, Training & Services

Attachment

pgsql-hackers by date:

Previous
From: Ildus Kurbangaliev
Date:
Subject: [PATCH] Refactoring of LWLock tranches
Next
From: Bruce Momjian
Date:
Subject: Re: Is this a bug?