Re: Remove win32ver.rc from version_stamp.pl - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Remove win32ver.rc from version_stamp.pl
Date
Msg-id 5599e5cb-7d07-c4fc-24f9-273c4b7a2eec@2ndquadrant.com
Whole thread Raw
In response to Re: Remove win32ver.rc from version_stamp.pl  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Remove win32ver.rc from version_stamp.pl  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 2020-03-01 23:51, Tom Lane wrote:
> In general, while I'm on board with the idea, I wonder whether it
> wouldn't be smarter to keep on defining PG_MAJORVERSION as a string,
> and just add PG_MAJORVERSION_NUM alongside of it.  This would
> eliminate some hunks from the patch in places where it's more
> convenient to have the version as a string, and it would avoid
> what could otherwise be a pretty painful cross-version incompatibility
> for extensions.  We already provide PG_VERSION in both forms, so
> I don't see any inconsistency in doing likewise for PG_MAJORVERSION.

Agreed.  Here is another patch.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment

pgsql-hackers by date:

Previous
From: Julien Rouhaud
Date:
Subject: Re: reindex concurrently and two toast indexes
Next
From: Michael Paquier
Date:
Subject: Re: Add an optional timeout clause to isolationtester step.