Re: Re: [COMMITTERS] pgsql: Another attempt at fixing Windows Norwegian locale. - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: Re: [COMMITTERS] pgsql: Another attempt at fixing Windows Norwegian locale.
Date
Msg-id 54CE6643.90406@vmware.com
Whole thread Raw
In response to Re: Re: [COMMITTERS] pgsql: Another attempt at fixing Windows Norwegian locale.  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Re: [COMMITTERS] pgsql: Another attempt at fixing Windows Norwegian locale.  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 02/01/2015 04:56 PM, Tom Lane wrote:
> Heikki Linnakangas <hlinnakangas@vmware.com> writes:
>> On 01/31/2015 09:52 PM, Tom Lane wrote:
>>> What advice do we need to give 9.4 users?
>
>> I just downloaded the 9.4 EDB Windows installer and tried installing it.
>> initdb fails with the same error that I got after upgrading to more
>> recent MSVC version. "select version()" on the EDB binaries says:
>
>>                              version
>> -------------------------------------------------------------
>>    PostgreSQL 9.4.0, compiled by Visual C++ build 1800, 64-bit
>> (1 row)
>
>> So there shouldn't be any existing Windows 9.4 installations that need
>> manual fixing, because the current binaries will just fail.
>
>> If there are any Norwegian users that have built Windows binaries
>> themselves, though, using an older MSVC version, then they would need to
>> follow the same manual fix-up steps to replace the "norwegian-bokmal"
>> locale names in pg_database with "Norwegian_Norway". Until they do,
>> CREATE DATABASE won't work (except with template=template0).
>
>> I suggest that we simply remove the notice about running the manual
>> steps from the 9.4.1 release notes.
>
> Hm.  My understanding of the situation was that the "norwegian-bokmal"
> solution worked on some Windows versions but not others.

I'm no Windows expert, but believe that it's not the Windows version 
you're running on that matters, but the CRT library used when building 
the binaries.

> So it seems like the risk for 9.4 users is that they installed on a
> version where "norwegian-bokmal" works and then someday want to
> migrate the database to one where it doesn't.  Maybe we don't need to
> address that, but I'm strongly tempted to keep the same instructions
> but phrase them as "change norwegian-bokmal to Norwegian_Norway if
> it's there".

That's fine by me, that advice is correct, although I believe that you 
only encounter that situation if you had built the binaries yourself 
with an older MSVC version.

- Heikki




pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Re: [COMMITTERS] pgsql: Another attempt at fixing Windows Norwegian locale.
Next
From: Heikki Linnakangas
Date:
Subject: Re: longjmp clobber warnings are utterly broken in modern gcc