Re: Commitfest problems - Mailing list pgsql-hackers

From Josh Berkus
Subject Re: Commitfest problems
Date
Msg-id 5490763C.5080808@agliodbs.com
Whole thread Raw
In response to Re: Commitfest problems  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
On 12/16/2014 08:48 AM, Mike Blackwell wrote:
> On Tue, Dec 16, 2014 at 10:15 AM, Mark Cave-Ayland
> <mark.cave-ayland@ilande.co.uk <mailto:mark.cave-ayland@ilande.co.uk>>wrote:
>
>
>     Well as I mentioned in my last email, practically all developers will
>     rebase and run "make check" on their patched tree before submitting to
>     the list.
>
>
> ​Even when this is true, and with people new to the project submitting
> patches
> I'm not sure it can be assumed, time passes and things can change between
> submission​ and review.  I've seen a fair number of "Needs rebase" comments
> on patches, through no fault of the original submitter.

This really should be taken care of by automation.  Magnus's new system
will be a significant step forwards on enabling that.

--
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com



pgsql-hackers by date:

Previous
From: Teodor Sigaev
Date:
Subject: Re: compress method for spgist - 2
Next
From: Stephen Frost
Date:
Subject: Re: Commitfest problems