Re: automatic restore point - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: automatic restore point
Date
Msg-id 544ca174-f0a1-fe75-ce74-3625fbc09447@2ndquadrant.com
Whole thread Raw
In response to Re: automatic restore point  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: automatic restore point  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
On 01/10/2018 05:34, Alvaro Herrera wrote:
> I don't see it as clear cut as all that ... particularly considering
> that a useful event trigger runs *after* the DDL command in question has
> already written all its WAL, so such a restore point would be completely
> useless.  (Or are ddl_command_start event triggers useful enough?)

The following appears to work:

CREATE FUNCTION evt_automatic_restart_point() RETURNS event_trigger
LANGUAGE plpgsql
AS $$
BEGIN
  PERFORM pg_create_restore_point(tg_tag);
END
$$;

CREATE EVENT TRIGGER automatic_restart_point ON ddl_command_start
    EXECUTE PROCEDURE evt_automatic_restart_point();

Are there any concerns about this?

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: executor relation handling
Next
From: Tom Lane
Date:
Subject: Re: Assert failed in snprintf.c