Re: pgsql-server/src/backend catalog/index.c comma ... - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql-server/src/backend catalog/index.c comma ...
Date
Msg-id 5428.1064534648@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql-server/src/backend catalog/index.c comma ...  ("Hiroshi Inoue" <inoue@tpf.co.jp>)
Responses Re: pgsql-server/src/backend catalog/index.c comma ...  ("Hiroshi Inoue" <Inoue@tpf.co.jp>)
List pgsql-committers
"Hiroshi Inoue" <inoue@tpf.co.jp> writes:
>> Remove the 'index deactivation' code, since it provides
>> no useful protection in the shared- index case.

> Seems a funny reason to me.

Well, as you know I never liked that code; modifying permanent on-disk
data didn't seem like a sensible way to protect against intra-transaction
interlock problems.  So when I saw a chance to get rid of it, I thought
we should take it.

> I've spent a pretty much time only to put back your change.

Why?  As far as I know, the modified code does everything you want.

            regards, tom lane

pgsql-committers by date:

Previous
From: tgl@svr1.postgresql.org (Tom Lane)
Date:
Subject: pgsql-server/src backend/executor/execQual.c b ...
Next
From: tgl@svr1.postgresql.org (Tom Lane)
Date:
Subject: pgsql-server/src/backend/executor nodeTidscan.c