Re: pgsql-server/src/backend catalog/index.c comma ... - Mailing list pgsql-committers

From Hiroshi Inoue
Subject Re: pgsql-server/src/backend catalog/index.c comma ...
Date
Msg-id 002601c3837a$5af2b490$3d283ddb@PbgX
Whole thread Raw
In response to Re: pgsql-server/src/backend catalog/index.c comma ...  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql-server/src/backend catalog/index.c comma ...
List pgsql-committers
> -----Original Message-----
> From: Tom Lane [mailto:tgl@sss.pgh.pa.us]
>
> "Hiroshi Inoue" <inoue@tpf.co.jp> writes:
> >> I committed the fixes a few minutes ago.  I now actually
> believe that
> >> reindexing system tables works ;-) ... hopefully Hiroshi does too.
>
> > I don't see your commit message yet.
>
> CVS reports to the committers list seem to be wedged this
> afternoon :-(.
> I already complained to Marc about it.  But in the meantime
> here is the
> cvs2cl entry:
>
>     Remove the 'index deactivation' code, since it provides
> no useful
>     protection in the shared- index case.

Seems a funny reason to me.
Well, do you also remove reltuples or relpages from pg_class ?

As I already mentioned, I don't love the ReindexProcessing global
flag from the first. For example, it's not thread-safe.

> > Is it wrong to believe I have a right to conitune the discussion ?
>
> Not at all, but I already waited two days for your response,
> and I can't
> put development on hold indefinitely.

I've spent a pretty much time only to put back your change.
What I've got until now was just a temporary neutral state.
It's not a neutral state now again. Should I be satisfied with it ?

regards,
Hiroshi Inoue


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql-server/src/backend catalog/index.c comma ...
Next
From: momjian@svr1.postgresql.org (Bruce Momjian)
Date:
Subject: pgsql-server/doc FAQ_japanese src/FAQ/FAQ_japa ...