Re: pgsql: Treat 2PC commit/abort the same as regular xacts in recovery. - Mailing list pgsql-committers

On 07/29/2014 05:10 PM, Tom Lane wrote:
> Heikki Linnakangas <heikki.linnakangas@iki.fi> writes:
>> Treat 2PC commit/abort the same as regular xacts in recovery.
>
> Looking at this again ... didn't you just break recoveryStopsBefore?
> ISTM the added line
>
>     if (record_info == XLOG_XACT_COMMIT_PREPARED)
>
> needs to be
>
>     else if (record_info == XLOG_XACT_COMMIT_PREPARED)
>
> As it stands, control will reach the "return false" for regular
> commit records.

Oops :-(. Fixed, thanks!

- Heikki