Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: Treat 2PC commit/abort the same as regular xacts in recovery. - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Treat 2PC commit/abort the same as regular xacts in recovery.
Date
Msg-id 31263.1406643002@sss.pgh.pa.us
Whole thread Raw
In response to pgsql: Treat 2PC commit/abort the same as regular xacts in recovery.  (Heikki Linnakangas <heikki.linnakangas@iki.fi>)
Responses Re: pgsql: Treat 2PC commit/abort the same as regular xacts in recovery.  (Heikki Linnakangas <hlinnakangas@vmware.com>)
List pgsql-committers
Tree view 
Heikki Linnakangas <heikki.linnakangas@iki.fi> writes:
> Treat 2PC commit/abort the same as regular xacts in recovery.

Looking at this again ... didn't you just break recoveryStopsBefore?
ISTM the added line

    if (record_info == XLOG_XACT_COMMIT_PREPARED)

needs to be

    else if (record_info == XLOG_XACT_COMMIT_PREPARED)

As it stands, control will reach the "return false" for regular
commit records.

            regards, tom lane

pgsql-committers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: pgsql: Treat 2PC commit/abort the same as regular xacts in recovery.
Next
From: Heikki Linnakangas
Date:
Subject: pgsql: Oops, fix recoveryStopsBefore functions for regular commits.