Re: patch: make_timestamp function - Mailing list pgsql-hackers

From Jim Nasby
Subject Re: patch: make_timestamp function
Date
Msg-id 52B074EB.50609@nasby.net
Whole thread Raw
In response to Re: patch: make_timestamp function  (Pavel Stehule <pavel.stehule@gmail.com>)
Responses Re: patch: make_timestamp function
List pgsql-hackers
On 12/15/13, 12:59 PM, Pavel Stehule wrote:
>     Why wouldn't we have a version that optionally accepts the timezone? That mirrors what you can currently do with
acast from text, and having to set the GUC if you need a different TZ would be a real PITA.
 
>
>
> It is not bad idea.
>
> What will be format for timezone in this case? Is a doble enough?

Sorry for not seeing this earlier, but no, I think double is barking up the wrong tree. It should accept the same
timezoneidentifiers that the rest of the system does, like blah AT TIME ZONE foo and SET timezone = foo;
 

Specifically, it needs to support things like 'GMT' and 'CST6CDT'.

I can see an argument for another version that accepts numeric so if you want to do -11.5 you don't have to wrap it in
quotes...
-- 
Jim C. Nasby, Data Architect                       jim@nasby.net
512.569.9461 (cell)                         http://jim.nasby.net



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: commit fest 2013-11 final report
Next
From: Jim Nasby
Date:
Subject: Re: pg_rewarm status