Re: alter_table regression test problem - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: alter_table regression test problem
Date
Msg-id 527BADCF.4020807@dunslane.net
Whole thread Raw
In response to Re: alter_table regression test problem  (Andres Freund <andres@2ndquadrant.com>)
List pgsql-hackers
On 11/07/2013 09:59 AM, Andres Freund wrote:
> On 2013-11-07 06:49:58 -0800, Kevin Grittner wrote:
>> It's up to the committer whether to indent
>> after review and make both substantive and whitespace changes
>> together, but I have definitely seen those done separately, or even
>> left for the next global pgindent run to fix.
> Hm. I don't remember many such cases and I've just looked across the git
> history and i didn't really find anything after
> a04161f2eab55f72b3c3dba9baed0ec09e7f633f, but that was back when
> individuals couldn't run pgindent because of the typedefs file.
>


Perhaps we need more frequent pgindent runs.

both patch and git-apply have options to ignore whitespace changes.

cheers

andrew





pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: alter_table regression test problem
Next
From: Antonin Houska
Date:
Subject: Comment - uniqueness of relfilenode