Re: Prevent pg_basebackup -Fp -D -? - Mailing list pgsql-hackers

From Josh Berkus
Subject Re: Prevent pg_basebackup -Fp -D -?
Date
Msg-id 524CC40F.1000506@agliodbs.com
Whole thread Raw
In response to Prevent pg_basebackup -Fp -D -?  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
On 10/02/2013 05:47 PM, Michael Paquier wrote:
> On Wed, Oct 2, 2013 at 11:31 PM, Magnus Hagander <magnus@hagander.net> wrote:
>> Right now, if you use
>>
>> pg_basebackup -Ft -D -
>>
>> you get a tarfile, written to stdout, for redirection.
>>
>> However, if you use:
>>
>> pg_basebackup -Fp -D -
>>
>> you get a plaintext (unpackaged) backup, in a directory called "-".
>>
>> I can't think of a single usecase where this is a good idea. Therefor,
>> I would suggest we simply throw an error in this case, instead of
>> creating the directory. Only for the specific case of specifying
>> exactly "-" as a directory.
>>
>> Comments?

I can see fixing this going forwards, but it doesn't seem worth
backpatching.

-- 
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Prevent pg_basebackup -Fp -D -?
Next
From: Magnus Hagander
Date:
Subject: Re: Prevent pg_basebackup -Fp -D -?