Re: Kudos for Reviewers -- wrapping it up - Mailing list pgsql-hackers

From Josh Berkus
Subject Re: Kudos for Reviewers -- wrapping it up
Date
Msg-id 51E03BB0.7080803@agliodbs.com
Whole thread Raw
In response to Re: Kudos for Reviewers -- straw poll  ("Greg Sabino Mullane" <greg@turnstep.com>)
Responses Re: Kudos for Reviewers -- wrapping it up
List pgsql-hackers
Folks,

Well, I didn't get much in the way of "poll" responses for the straw
poll.  However, let me sum up:

-- two hackers thought that reviewers didn't deserve any credit at all.

-- of the majority of respondants, things were about evenly split
between people who favored "big list at the end" and people who favored
"reviewer next to feature".  Notably, those who favored "reviewer next
to feature" also thought that our standards for what constitutes a
"review" should be more stringent.

-- reviewers, in general, were unanimous that the only thing which
mattered in terms of "rewarding" reviewers was credit in the release
notes, and that other "rewards" were nice but inconsequential.

-- a couple of compromise proposals were made:

a) that reviewers who do actual code modification of the patch get
credited on the feature, and those who just review it get credited at
the bottom of the release notes, or

b) that all "names" move to a web page on www.postgresql.org and come
out of the release notes entirely.

Speaking as a commitfest manager, I favor compromise proposal (a),
personally.   Does (a) seem somehow terrible to anyone?

-- 
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com



pgsql-hackers by date:

Previous
From: David Johnston
Date:
Subject: Re: column "b" is of type X but expression is of type text
Next
From: Alvaro Herrera
Date:
Subject: Re: Kudos for Reviewers -- wrapping it up