Re: [HACKERS] [COMMITTERS] pgsql: Add function to import operating system collations - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [HACKERS] [COMMITTERS] pgsql: Add function to import operating system collations
Date
Msg-id 5104.1485030499@sss.pgh.pa.us
Whole thread Raw
In response to [HACKERS] Re: [COMMITTERS] pgsql: Add function to import operating systemcollations  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: [HACKERS] [COMMITTERS] pgsql: Add function to import operatingsystem collations  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> On 1/21/17 12:50 PM, Tom Lane wrote:
>> I have to question the decision to make "no locales" a hard error.
>> What's the point of that?  In fact, should we even be bothering with
>> a warning, considering how often initdb runs unattended these days?

> Hmm, it was a warning in initdb, so making it an error now is probably a
> mistake.  We should change it back to a warning at least.

I'd drop it altogether I think ... it was useful debug back in the day
but now I doubt it is worth much.

> Also, if we add ICU initialization to this, then it's not clear how we
> would report if one provider provided zero locales but another did
> provide some.

Would it help to redefine the function as returning the number of locale
entries it successfully added?
        regards, tom lane



pgsql-hackers by date:

Previous
From: "Greg Sabino Mullane"
Date:
Subject: Re: [HACKERS] Checksums by default?
Next
From: Tom Lane
Date:
Subject: Re: [HACKERS] Failure in commit_ts tap tests