Re: pgsql: Silence compiler warning about pointer type mismatch on some pla - Mailing list pgsql-committers

From Heikki Linnakangas
Subject Re: pgsql: Silence compiler warning about pointer type mismatch on some pla
Date
Msg-id 506B1DEA.4070904@vmware.com
Whole thread Raw
In response to Re: pgsql: Silence compiler warning about pointer type mismatch on some pla  (Fujii Masao <masao.fujii@gmail.com>)
List pgsql-committers
On 02.10.2012 19:33, Fujii Masao wrote:
> On Tue, Oct 2, 2012 at 11:47 PM, Heikki Linnakangas
> <heikki.linnakangas@iki.fi>  wrote:
>> Silence compiler warning about pointer type mismatch on some platforms.
>>
>> timeval.t_sec is of type time_t, which is not always compatible with long.
>> I'm not sure if this was just harmless warning or a real bug, but this
>> fixes it, anyway.
>
> +                timeout.tv_sec = usecs;
>
> This code looks like a bug. No? I think the attached patch should be applied.

Sigh, yes. Thanks for paying more attention than me..

- Heikki


pgsql-committers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: pgsql: Fix typo in previous warning-silencing patch.
Next
From: Fujii Masao
Date:
Subject: Re: pgsql: Split off functions related to timeline history files and XLOG a