Re: pg_upgrade del/rmdir path fix - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: pg_upgrade del/rmdir path fix
Date
Msg-id 5046A2BE.5090009@dunslane.net
Whole thread Raw
In response to Re: pg_upgrade del/rmdir path fix  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
On 09/04/2012 02:25 PM, Andrew Dunstan wrote:
>
> On 09/04/2012 10:42 AM, Alvaro Herrera wrote:
>
>>
>> Somehow the verbose reporting of user relation files being copied does
>> not seem exceedingly useful; and I don't remember seeing that on Linux.
>>
>
>
> Yeah, and it does something odd anyway when it's not writing to a
> terminal. Can we get rid of it, or make it only work in verbose mode?
>
>

The attached is an attempt to fix this. I think it handles most of
what's wrong with this. (The patch is bigger because the code currently
uses a variable called "fileno" - not a good idea.)

cheers

andrew



Attachment

pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: build farm machine using mixed results
Next
From: Bruce Momjian
Date:
Subject: Re: pg_upgrade diffs on WIndows