CREATE DATABASE copies datlocale even if datlocprovider differs - Mailing list pgsql-bugs

From Jeff Davis
Subject CREATE DATABASE copies datlocale even if datlocprovider differs
Date
Msg-id 5038b33a6dc639009f4b3d43fa6ae0c5ba9e04f7.camel@j-davis.com
Whole thread Raw
List pgsql-bugs
  initdb -D data --locale-provider=builtin --builtin-locale='C.UTF-8'
  CREATE DATABASE d2 TEMPLATE template0 LOCALE_PROVIDER 'icu';
  WARNING:  ICU locale "C.UTF-8" has unknown language "c"
  HINT:  To disable ICU locale validation, set the parameter
"icu_validation_level" to "disabled".
  CREATE DATABASE

  SELECT datlocale FROM pg_database WHERE datname='d2';
   datlocale
  -----------
   C.UTF-8
  (1 row)

It's only an issue if template0 is builtin and the new database is icu.
libc doesn't use the datlocale field, and the builtin provider will
reject ICU locale names. ICU is less strict for historical reasons.

I think that should throw an error rather than trying to reinterpret
datlocale for the new provider. Patch attached, intended to backport
through 17.

In theory that could break existing CREATE DATABASE commands, but given
that it's such a narrow case I don't think it's a major problem. We
could mitigate it by patching only 18+. Thoughts?

Regards,
    Jeff Davis


Attachment

pgsql-bugs by date:

Previous
From: Jacob Champion
Date:
Subject: Re: BUG #19002: `pg_isready` unexpectedly succeeds on incorrect `--dbname` and/or `--username`
Next
From: Samuel Marks
Date:
Subject: Re: BUG #19002: `pg_isready` unexpectedly succeeds on incorrect `--dbname` and/or `--username`