Re: [COMMITTERS] pgsql: Remove prepared transactions from main isolation test schedule. - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [COMMITTERS] pgsql: Remove prepared transactions from main isolation test schedule.
Date
Msg-id 500.1342815428@sss.pgh.pa.us
Whole thread Raw
Responses Re: [COMMITTERS] pgsql: Remove prepared transactions from main isolation test schedule.  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
Andrew Dunstan <andrew@dunslane.net> writes:
> Remove prepared transactions from main isolation test schedule.

> There is no point in running this test when prepared transactions are disabled,
> which is the default. New make targets that include the test are provided. This
> will save some useless waste of cycles on buildfarm machines.

Having done that, shouldn't we remove prepared-transactions_1.out (the
"expected" file for the prepared-transactions-disabled case)?

Having a megabyte-sized test file for that case has always seemed pretty
wasteful to me.  Now that the test won't be run unless intentionally
selected, it seems like people who are using it would expect it to
actually test prepared transactions --- so having it "pass" when they're
disabled seems wrong.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: CHECK NO INHERIT syntax
Next
From: Andrew Dunstan
Date:
Subject: Re: [COMMITTERS] pgsql: Remove prepared transactions from main isolation test schedule.