Re: [Bug Fix] ECPG: could not use set xxx to default statement - Mailing list pgsql-hackers

From Michael Meskes
Subject Re: [Bug Fix] ECPG: could not use set xxx to default statement
Date
Msg-id 4c0ccf08b3c1af65c19d361bce122e539a59eed1.camel@postgresql.org
Whole thread Raw
In response to RE: [Bug Fix] ECPG: could not use set xxx to default statement  ("Higuchi, Daisuke" <higuchi.daisuke@jp.fujitsu.com>)
Responses Re: [Bug Fix] ECPG: could not use set xxx to default statement
List pgsql-hackers
Higuchi-san,

> I attached the patch which cope with missing semicolons. 
> Previous parse.pl find semicolon and dump data to buffer. When
> attached patch's parse.pl find new tokens before finding a semicolon,
> it also dumps data to buffer.

It just occurred to me that check_rules.pl probably uses the same logic
to identify each rule and thus needs to be changed, too. 

Also, IIRC bison allows blanks between the symbol name and the colon,
or in other words "generic_set:" is equal to "generic_set :". If this
happens after a "missing" semicolon I think your patch does not notice
the end of the rule.

Michael
-- 
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Meskes at (Debian|Postgresql) dot Org
Jabber: michael at xmpp dot meskes dot org
VfL Borussia! Força Barça! SF 49ers! Use Debian GNU/Linux, PostgreSQL



pgsql-hackers by date:

Previous
From: Surafel Temesgen
Date:
Subject: Re: Conflict handling for COPY FROM
Next
From: Tomas Vondra
Date:
Subject: Re: Protect syscache from bloating with negative cache entries