Re: regress bug - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: regress bug
Date
Msg-id 4F5914AB.4040102@pgexperts.com
Whole thread Raw
In response to Re: regress bug  ("David E. Wheeler" <david@justatheory.com>)
Responses Re: regress bug  ("David E. Wheeler" <david@justatheory.com>)
List pgsql-hackers
On 03/08/2012 02:59 PM, David E. Wheeler wrote:
> On Mar 8, 2012, at 10:22 AM, Andrew Dunstan wrote:
>
>> This seems like an outright bug. I don't recall any discussion on it. Maybe nobody's come across it before. ISTM the
correctbehaviour would be to put converted sql files in $inputdir/sql and converted results files in
$outputdir/expected.
> In my extension distributions, I have
>
>      tests/sql
>      tests/expected
>
> And for that, --inputdir=test works just fine. I don't mess with --outputdir, which just seems to affect where the
actualoutput is written to, which is just a directory named regression.out at the top of the project. 
>

It works fine if you don't need to do any file conversions (i.e. if you
don't have "input" or "output" directories). But file_textarray_fdw does.

Here's a patch that I think fixes the problem.

cheers

andrew



Attachment

pgsql-hackers by date:

Previous
From: "David E. Wheeler"
Date:
Subject: Re: regress bug
Next
From: "David E. Wheeler"
Date:
Subject: Re: regress bug