Re: PL/Perl Does not Like vstrings - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: PL/Perl Does not Like vstrings
Date
Msg-id 4F05E859.1000701@dunslane.net
Whole thread Raw
In response to Re: PL/Perl Does not Like vstrings  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers

On 01/05/2012 01:09 PM, Tom Lane wrote:
> Andrew Dunstan<andrew@dunslane.net>  writes:
>> The fix that has been applied, as Tom suggested, is at the point where
>> we call SvPVutf8(), so that's not just for elog().
> That patch looks good, but do we want to look into the other point about
> error recovery?  The real bottom line here is that when SvPVutf8 threw a
> croak(), we didn't recover sanely at all --- in fact, it was almost
> impossible to tell what had happened even in gdb, until I installed
> perl debugging symbols and single-stepped through things.  I would have
> hoped that we'd at least see the croak message.  This seems a bit
> nervous-making, as plperl sure calls a lot of stuff that in principle
> could croak.
>
>             

Yes, I think so. That seemed like a separate issue, though, which is why 
I just applied the workaround to the reported problem. I had similar 
issues with gdb - it wasn't a pleasant experience.

cheers

andrew



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: PL/Perl Does not Like vstrings
Next
From: Simon Riggs
Date:
Subject: Re: CLOG contention