Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Use CC atomic builtins if available [was: Re: TAS patch for building on armel/armhf thumb] - Mailing list pgsql-bugs

From Heikki Linnakangas
Subject Re: [PATCH] Use CC atomic builtins if available [was: Re: TAS patch for building on armel/armhf thumb]
Date
Msg-id 4EEF63E3.2010602@enterprisedb.com
Whole thread Raw
In response to Re: [PATCH] Use CC atomic builtins if available [was: Re: TAS patch for building on armel/armhf thumb]  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-bugs
Tree view 
On 19.12.2011 17:25, Tom Lane wrote:
> Heikki Linnakangas<heikki.linnakangas@enterprisedb.com>  writes:
>> On 19.12.2011 16:31, Robert Haas wrote:
>> Actually, I believe our Itanium (and possibly ARM, too) implementation
>> of S_UNLOCK() is wrong as it is.
>
> Hmm.  Anybody got a large itanium box we could play with?  If it is
> wrong, I'd expect it would show up pretty quickly under pgbench or
> similar.

We've been running pgbench heavily recently in the company on large HP
Itanium boxes with 32 and 64 cores, and haven't seen any issues. I'm not
sure how it would manifest itself, though. It's also possible that while
it's a genuine bug at the source level, it happens to be masked by some
compiler decisions. It sure looks wrong.

I'll try to construct a self-contained test program to exercise that.

--
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com

pgsql-bugs by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: [PATCH] Use CC atomic builtins if available [was: Re: TAS patch for building on armel/armhf thumb]
Next
From: Martin Pitt
Date:
Subject: [PATCH v2] Use CC atomic builtins as a fallback