Postgres Pro
Downloads
Home   >   mailing lists

[PATCH v2] Use CC atomic builtins as a fallback - Mailing list pgsql-bugs

From Martin Pitt
Subject [PATCH v2] Use CC atomic builtins as a fallback
Date
Msg-id 20111219171145.GN2972@piware.de
Whole thread Raw
In response to Re: [PATCH] Use CC atomic builtins if available [was: Re: TAS patch for building on armel/armhf thumb]  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: [PATCH v2] Use CC atomic builtins as a fallback  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-bugs
Tree view 
Robert Haas [2011-12-19  9:31 -0500]:
> -1.  Absent some evidence that gcc's implementations are superior to
> ours, I think we should not change stuff that works now.  That's
> likely to lead to subtle bugs that are hard to find and perhaps
> dependent on the exact compiler version used.
>
> But I'm completely cool with doing this for platforms where we haven't
> otherwise got an implementation.  Any port in a storm.

The updated patch only uses the gcc builtins if there is no explicit
implementation, but drops the arm one as this doesn't work on ARMv7
and newer, as stated in the original mail.

Thanks,

Martin
--
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)
Attachment

pgsql-bugs by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: [PATCH] Use CC atomic builtins if available [was: Re: TAS patch for building on armel/armhf thumb]
Next
From: Alvaro Herrera
Date:
Subject: Re: BUG #6346: unsubscribe doesn't work