RE: idle-in-transaction timeout error does not give a hint - Mailing list pgsql-hackers

From Ideriha, Takeshi
Subject RE: idle-in-transaction timeout error does not give a hint
Date
Msg-id 4E72940DA2BF16479384A86D54D0988A6F3C2DA3@G01JPEXMBKW04
Whole thread Raw
In response to Re: idle-in-transaction timeout error does not give a hint  (Tatsuo Ishii <ishii@sraoss.co.jp>)
Responses Re: idle-in-transaction timeout error does not give a hint
List pgsql-hackers
>From: Tatsuo Ishii [mailto:ishii@sraoss.co.jp]
>Subject: Re: idle-in-transaction timeout error does not give a hint
>
>>>>>>Alternative HINT message would be something like:
>>>>>>
>>>>>>HINT: In a moment you should be able to reconnect to the
>>>>>>      database and restart your transaction.
>>>>>>
>>>>>>This could make the meaning of the error (transaction aborted)
>>>>>>cleaner and might give a better suggestion to the user.
>>>>>
>>>>> Agreed. Changing "command" to "transaction" seems more accurate.
>>>>> People might think only the command they hit is not sent but
>>>>> transaction is still alive though it's of course unnatural that
>>>>> transaction is alive after
>>>connection is terminated.
>>
>>
>>>Please find attached patch which addresses the point above.
>> Thank you for the update. It looks good to me on this point.
>> Are you planning to change other similar messages?
>
>No, because this is the only message related to an explicit transaction.  Other
>messages are not related to explicit transactions, so current messages look ok to me.

Sure. I didn't have a strong opinion about it, so it's ok.

Regards,
Takeshi Ideriha



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [Todo item] Add entry creation timestamp column topg_stat_replication
Next
From: Peter Geoghegan
Date:
Subject: Re: Making all nbtree entries unique by having heap TIDs participatein comparisons